Remove dead code and fix unused parameter in Event.refresh#24
Merged
Conversation
Remove unused navigationPathStats state variable from AppTabView and fix Event.refresh to use the action parameter instead of hardcoding "Refresh". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…undaries Remove unnecessary sending keyword from NFCManagerProtocol.startWriting and use nonisolated(unsafe) in ItemTagDetailViewModel to safely transfer the NFCNDEFMessage to the nonisolated method. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigationPathStatsstate variable fromAppTabView— was declared and assigned but never passed to anyNavigationStackEvent.refreshto use theactionparameter instead of ignoring it and hardcoding"Refresh"Test plan
🤖 Generated with Claude Code